Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for attachments once discord.js 11.2.0 is released #47

Closed
anoadragon453 opened this issue Sep 17, 2017 · 2 comments
Closed

Check for attachments once discord.js 11.2.0 is released #47

anoadragon453 opened this issue Sep 17, 2017 · 2 comments
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.

Comments

@anoadragon453
Copy link
Member

        };
        // Uncomment this and remove !hasAttachment above after https://github.com/hydrabolt/discord.js/pull/1449 pulled
        // if (hasAttachment) {
        //   hookOpts.file = opts.file;
        //   msg = await hook.send(embed.description, hookOpts);
        // } else {
        msg = await hook.send(embed.description, hookOpts);
// }

From: https://github.com/Half-Shot/matrix-appservice-discord/blob/develop/src/bot.ts#L206

discordjs/discord.js#1449 is now merged, so maybe you want to uncomment it? :P

@Half-Shot
Copy link
Contributor

This would require upgrading to 11.2.0, so I'll leave it until release 0.1.0 comes out.

@anoadragon453 anoadragon453 changed the title Might want to uncomment this code now Check for attachments once discord.js 11.2.0 is released Sep 27, 2017
@Half-Shot
Copy link
Contributor

This has since been fixed in d123d5f

@jaller94 jaller94 added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. and removed feature labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.
Projects
None yet
Development

No branches or pull requests

3 participants