Add denied/allowed permissions to PermissionOverwrites #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tbh i would change the private props to |
This could possible break if people use deny/allow, I assume, but that's okay.
|
@devsnek 👍 |
appellation
approved these changes
Jun 4, 2017
|
"Thanks Crawl for fixing my derp" said @FireController1847 never 🤣 Make sure if you rename stuff, to rename all occasions. |
|
Oh shiz yeah thanks lmao |
Ratismal
pushed a commit
to Ratismal/discord.js
that referenced
this pull request
Jul 5, 2017
* Add denied/allowed permissions to PermissionOverwrites * Remove one accidental trailing space. * Change to _denied/_allowed & denied/allowed This could possible break if people use deny/allow, I assume, but that's okay. * Update PermissionOverwrites.js * Update PermissionOverwrites.js
Ratismal
pushed a commit
to Ratismal/discord.js
that referenced
this pull request
Jul 5, 2017
…relevant property names as of discordjs#1562 (discordjs#1570) * using correct properties to apply permissionOverwrites and fixed `GuildChannel#clone` * also arrays should be mapped and correct properties taking priority * changed .deny and .allow to .denied and .allowed respectively * whoops
This was referenced Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
At the moment, on the docs, it lacks any documentation on how to get permissions from the PermissionOverwrites. I'm not very good at this, and if I need to change something please tell me, but this is my attempt to add support for the allowed/denied permissions on PermissionOverwrites.
Semantic versioning classification: