Correctly mapping overwrites when creating a channel and renamed all relevant property names as of #1562 #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fixed `GuildChannel#clone`
SpaceEEC
changed the title
PgBiel
suggested changes
Jun 7, 2017
| if (overwrites instanceof Collection) overwrites = overwrites.array(); | ||
| if (overwrites instanceof Collection || overwrites instanceof Array) { | ||
| overwrites = overwrites.map(overwrite => ({ | ||
| allow: overwrite.allow || overwrite._allowed, |
| if (overwrites instanceof Collection || overwrites instanceof Array) { | ||
| overwrites = overwrites.map(overwrite => ({ | ||
| allow: overwrite.allow || overwrite._allowed, | ||
| deny: overwrite.deny || overwrite._denied, |
SpaceEEC
changed the title
bdistin
reviewed
Jun 15, 2017
src/structures/GuildChannel.js
Outdated
| permissions &= ~overwrites.everyone.deny; | ||
| permissions |= overwrites.everyone.allow; | ||
| permissions &= ~overwrites.everyone._denied; | ||
| permissions |= overwrites.everyone._alloweded; |
Ratismal
pushed a commit
to Ratismal/discord.js
that referenced
this pull request
Jul 5, 2017
…relevant property names as of discordjs#1562 (discordjs#1570) * using correct properties to apply permissionOverwrites and fixed `GuildChannel#clone` * also arrays should be mapped and correct properties taking priority * changed .deny and .allow to .denied and .allowed respectively * whoops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Since those two properties were renamed PermissionOverwrites require mapping before sending them to discord.
Changing the names of the properties back would be a better solution IMO.
Also passing now the overwrites as correct parameter when cloning a channel.
Edit:
Changed all
.denyand.allowfor permission related methods inGuildChannelto their new property names.Related to #1595's problem with
.joinablebeing incorrectlytrue.Semantic versioning classification: