Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure VIEW_CHANNEL permissions before trying to join #3046

Merged
merged 3 commits into from
Feb 10, 2019
Merged

fix: ensure VIEW_CHANNEL permissions before trying to join #3046

merged 3 commits into from
Feb 10, 2019

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Feb 2, 2019

Please describe the changes this PR makes and why it should be merged:

This PR adds GuildChannel#viewable and adds it as requirement to VoiceChannel#joinable.
Fixes #3005 as VoiceChannel#join will now early reject with a more appropriate error.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@amishshah amishshah merged commit 7324a99 into discordjs:master Feb 10, 2019
@SpaceEEC SpaceEEC deleted the fix/voice_join_view branch June 27, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpaceEEC @kyranet @amishshah