fix end method in VoiceBroadcast #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.client is a ClientVoiceManager and thus its this.client.broadcasts instead of this.client.voice.broascasts
1 task
vladfrangu
requested changes
Apr 9, 2019
src/client/voice/VoiceBroadcast.js
Outdated
| @@ -67,8 +67,8 @@ class VoiceBroadcast extends EventEmitter { | |||
| */ | |||
| end() { | |||
| for (const dispatcher of this.dispatchers) this.delete(dispatcher); | |||
| const index = this.client.voice.broadcasts.indexOf(this); | |||
| if (index !== -1) this.client.voice.broadcasts.splice(index, 1); | |||
| const index = this.client.broadcasts.indexOf(this); | |||
There was a problem hiding this comment.
Can you rename the client variable to voiceManager, including updating the jsdocs in the constructor? That way it's correctly showing what it is
There was a problem hiding this comment.
Or pass client when constructing VoiceBroadcast:
There was a problem hiding this comment.
i think its better to pass the client
There was a problem hiding this comment.
just change the pull to change the this.client
const broadcast = new VoiceBroadcast(this.client);
SpaceEEC
approved these changes
Apr 11, 2019
vladfrangu
approved these changes
Apr 11, 2019
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
* fix end method in VoiceBroadcast this.client is a ClientVoiceManager and thus its this.client.broadcasts instead of this.client.voice.broascasts * revert the voicebroadcast and pass this.client at clientvoice * passed this.client
samsamson33
added a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
This reverts commit 522fcd3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.client is a ClientVoiceManager and thus its this.client.broadcasts instead of this.client.voice.broascasts
Please describe the changes this PR makes and why it should be merged:
Status
Semantic versioning classification: