-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Teams): backport support for teams #3357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
src/structures/OAuth2Application.js
Outdated
* The owning team of this OAuth application | ||
* @type {?Team} | ||
*/ | ||
this.team = new Team(this.client, data.team); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The team property should always exist as null or Team, not excluding the property if no data.team, so the object keeps consistent shape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, and also, it should be deprecated since it will be gone in v12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would such a deprecation look like? Emitting a process warning on access seems unjustified as there is no way to fix this before v12. Maybe a warn or info in the documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At minimum just a docstring @deprecated. But probably that with an explanation (in a warn or info tag) in the description.
Please describe the changes this PR makes and why it should be merged:
This PR backports #3350 (a22aabf) in a semver-minor manner.
(Namingly adding a
team
property opposed to replacingowner
)Status
Semantic versioning classification: