Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ClientUser) verified and enabled properties resetting #3733

Merged
merged 4 commits into from
Jan 25, 2020
Merged

fix(ClientUser) verified and enabled properties resetting #3733

merged 4 commits into from
Jan 25, 2020

Conversation

NotSugden
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR fixes ClientUser#verified and ClientUser#mfaEnabled properties resetting when something triggers the _patch method, by only setting the properties if they exist in the data

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@NotSugden NotSugden mentioned this pull request Jan 21, 2020
Closed
1 task
amishshah
amishshah previously requested changes Jan 23, 2020
View reviewed changes
src/structures/ClientUser.js Show resolved Hide resolved
SpaceEEC
SpaceEEC previously requested changes Jan 24, 2020
View reviewed changes
src/structures/ClientUser.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC dismissed their stale review January 24, 2020 15:32

can't fix this

advaith1
advaith1 suggested changes Jan 25, 2020
View reviewed changes
src/structures/ClientUser.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC dismissed amishshah’s stale review January 25, 2020 14:08

requested changes were applied

@SpaceEEC SpaceEEC merged commit 3ea9ac5 into discordjs:master Jan 25, 2020
@NotSugden NotSugden deleted the patch-3 branch February 14, 2020 00:36
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@NotSugden @samsamson33
fix(ClientUser): verified and enabled properties resetting (discordjs…
01c511b 
…#3733)

* fix(ClientUser) verified and enabled properties resetting

* set this.mfaEnabled to null if it is undefined

* add missing curly brackets

* fix typo
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@samsamson33
Revert "fix(ClientUser): verified and enabled properties resetting (d…
4a1929e 
…iscordjs#3733)"

This reverts commit 01c511b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monbrey monbrey monbrey approved these changes

@amishshah amishshah amishshah left review comments

@advaith1 advaith1 advaith1 approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@RDambrosio016 RDambrosio016 RDambrosio016 approved these changes

@MBR-0001 MBR-0001 MBR-0001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NotSugden @monbrey @amishshah @advaith1 @SpaceEEC @RDambrosio016 @MBR-0001