Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Message): Handle undefined/null content in Message#cleanContent #3778

Merged
merged 3 commits into from
Feb 12, 2020

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Feb 12, 2020

This prevents an error being thrown internally from Util#cleanContent when the Message#cleanContent getter is accessed on a Partial Message.

eslint intentionally disabled in order to use != to handle both undefined and null.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

typings/index.d.ts Outdated Show resolved Hide resolved
Co-Authored-By: SpaceEEC <spaceeec@yahoo.com>
@SpaceEEC SpaceEEC merged commit a36f386 into discordjs:master Feb 12, 2020
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
…iscordjs#3778)

* Handle undefined/null content in Message#cleanContent

* Typings

* Update typings/index.d.ts

Co-Authored-By: SpaceEEC <spaceeec@yahoo.com>

Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@monbrey monbrey deleted the cleanContent branch May 2, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants