feat(guildemojimanager): add delete and edit methods
#7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
ceilingfans
changed the title
delete and edit methods
vladfrangu
requested changes
Jan 17, 2022
kyranet
previously requested changes
Jan 17, 2022
There was a problem hiding this comment.
Please make GuildEmoji#edit and GuildEmoji#delete use the manager methods to reduce code duplication.
ImRodry
reviewed
Jan 17, 2022
ImRodry
reviewed
Jan 17, 2022
Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com>
SpaceEEC
approved these changes
Jan 17, 2022
vladfrangu
previously requested changes
Jan 17, 2022
…nto guildemojimanager-delete-edit # Conflicts: # packages/discord.js/src/managers/GuildEmojiManager.js
iCrawl
approved these changes
Jan 17, 2022
vladfrangu
approved these changes
Jan 17, 2022
kyranet
requested changes
Jan 17, 2022
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
ceilingfans
force-pushed
the
guildemojimanager-delete-edit
branch
from
5092ae5
to
6967a91
Compare
kyranet
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds the
deleteandeditmethods to theGuildEmojiManageras to use these methods, you would have to fetch the emoji from the manager before calling the methods on theGuildEmojiitself.Status and versioning classification: