feat: add methods to managers #7300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
force-pushed
the
feat-manager-methods
branch
from
81e9b50
to
b89d636
Compare
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
imranbarbhuiya
suggested changes
Jan 19, 2022
ImRodry
force-pushed
the
feat-manager-methods
branch
from
810d37b
to
1b88c12
Compare
suneettipirneni
requested changes
Jan 19, 2022
|
@iCrawl This should be semver minor, not major ? |
ImRodry
force-pushed
the
feat-manager-methods
branch
from
d4022fd
to
49bc8d3
Compare
kyranet
previously requested changes
Jan 26, 2022
ImRodry
force-pushed
the
feat-manager-methods
branch
from
0b298d6
to
1082340
Compare
|
Rebased and applied all suggestions! |
kyranet
approved these changes
Jan 26, 2022
ImRodry
force-pushed
the
feat-manager-methods
branch
2 times, most recently
from
b9c2667
to
10c2eea
Compare
Co-Authored-By: Parbez <imranbarbhuiya.fsd@gmail.com> Co-Authored-By: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Co-Authored-By: Antonio Román <kyradiscord@gmail.com>
ImRodry
force-pushed
the
feat-manager-methods
branch
from
10c2eea
to
a802ee8
Compare
iCrawl
approved these changes
Jan 28, 2022
vladfrangu
approved these changes
Jan 28, 2022
ImRodry
added a commit
to ImRodry/discord.js
that referenced
this pull request
Mar 6, 2022
Co-authored-by: Parbez <imranbarbhuiya.fsd@gmail.com> Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a bunch of methods to managers (without any intention to remove them from the structures of course). For some of these I had to use resolve instead of resolveId due to how the code works so if you believe this defeats the purpose of a manager method I can try refactoring or undoing some of those changes. This PR sort of continues the work from #7286
Status and versioning classification: