Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(guildchannelmanager): edit always sets parent to null #7446

Merged
merged 1 commit into from Feb 12, 2022
Merged

fix(guildchannelmanager): edit always sets parent to null #7446

merged 1 commit into from Feb 12, 2022

Conversation

muchnameless
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
oversight from #7300
currently editing a GuildChannel without passing parent sets parent_id to null

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

OshaDml
OshaDml reviewed Feb 11, 2022
View reviewed changes
Copy link

@OshaDml OshaDml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come teach me.

@SpaceEEC SpaceEEC added this to the discord.js v14 milestone Feb 11, 2022
@iCrawl iCrawl merged commit b97aedd into discordjs:main Feb 12, 2022
@muchnameless muchnameless deleted the channel-edit-fix branch February 12, 2022 10:39
ImRodry pushed a commit to ImRodry/discord.js that referenced this pull request Mar 6, 2022
@muchnameless @ImRodry
fix(guildchannelmanager): edit always sets parent to null (discordjs#…
4e87cf1 
…7446)
@ImRodry ImRodry mentioned this pull request Mar 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OshaDml OshaDml OshaDml left review comments

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@thebigwolfy thebigwolfy thebigwolfy approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:discord.js REST semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@muchnameless @iCrawl @kyranet @SpaceEEC @thebigwolfy @OshaDml