Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxyRequests): forward query parameters #8691

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

didinele
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Prior to this we weren't forwarding query parameters at all.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 1, 2022 at 1:40PM (UTC)

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #8691 (1864f47) into main (c69f512) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 1864f47 differs from pull request most recent head ab90283. Consider uploading reports for the commit ab90283 to get more accurate results

@@            Coverage Diff             @@
##             main    #8691      +/-   ##
==========================================
+ Coverage   86.79%   86.83%   +0.04%     
==========================================
  Files          85       85              
  Lines        8777     8799      +22     
  Branches     1109     1113       +4     
==========================================
+ Hits         7618     7641      +23     
+ Misses       1117     1116       -1     
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <100.00%> (+1.06%) ⬆️
rest 92.08% <100.00%> (+0.07%) ⬆️
utilities 100.00% <ø> (ø)
voice 63.83% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/proxy/src/handlers/proxyRequests.ts 73.91% <100.00%> (+2.27%) ⬆️
packages/rest/src/lib/RequestManager.ts 90.34% <100.00%> (+0.09%) ⬆️
...ackages/rest/src/lib/handlers/SequentialHandler.ts 86.44% <100.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit f063625 into discordjs:main Oct 1, 2022
@didinele didinele deleted the fix/proxy-query-param-forwarding branch October 1, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants