fix(SequentialHandler): throw http error with proper name and more useful message #8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
vladfrangu
approved these changes
Oct 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #8694 +/- ##
==========================================
+ Coverage 86.79% 86.82% +0.02%
==========================================
Files 85 84 -1
Lines 8777 8787 +10
Branches 1109 1107 -2
==========================================
+ Hits 7618 7629 +11
+ Misses 1117 1116 -1
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kyranet
approved these changes
Oct 1, 2022
iCrawl
approved these changes
Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR fixes #8615 by overwriting the error of
HTTPErrorwith the name of the class (as I think is how sub-classed errors should generally work) and synthesizing an error message based on the http status (as undici apparently does not expose the status text?).Status and versioning classification: