Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ClientApplication): add role connections #8855

Merged
merged 4 commits into from
Dec 24, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Nov 22, 2022

Please describe the changes this PR makes and why it should be merged:
Upstream;

Pending:

Status and versioning classification:

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
discord-js ⬜️ Ignored (Inspect) Dec 24, 2022 at 7:57AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 24, 2022 at 7:57AM (UTC)

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #8855 (069021e) into main (18b3a19) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 069021e differs from pull request most recent head 52f5dff. Consider uploading reports for the commit 52f5dff to get more accurate results

@@            Coverage Diff             @@
##             main    #8855      +/-   ##
==========================================
+ Coverage   84.35%   84.39%   +0.03%     
==========================================
  Files          98       98              
  Lines        9180     9158      -22     
  Branches     1096     1096              
==========================================
- Hits         7744     7729      -15     
+ Misses       1394     1387       -7     
  Partials       42       42              
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 98.45% <ø> (+0.22%) ⬆️
collection 100.00% <ø> (ø)
proxy 77.37% <ø> (ø)
rest 91.97% <ø> (ø)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.77% <ø> (ø)
ws 58.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lders/src/interactions/slashCommands/Assertions.ts 100.00% <0.00%> (+2.00%) ⬆️
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <0.00%> (+2.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite Jiralite removed the blocked label Dec 15, 2022
@kodiakhq kodiakhq bot merged commit 22e2bbb into discordjs:main Dec 24, 2022
@almeidx almeidx deleted the discord.js/role-connections branch December 24, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants