Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix actions type in automod #8962

Merged
merged 4 commits into from
Dec 25, 2022
Merged

types: fix actions type in automod #8962

merged 4 commits into from
Dec 25, 2022

Conversation

MrMythicalYT
Copy link
Contributor

@MrMythicalYT MrMythicalYT commented Dec 22, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:
This PR fixes the type for actions in AutoModerationRuleCreateOptions and setActions(). They should take an array.

Fixes #8963
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Dec 22, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
discord-js ⬜️ Ignored (Inspect) Dec 25, 2022 at 8:28PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 25, 2022 at 8:28PM (UTC)

@MrMythicalYT MrMythicalYT changed the title types(AutoModerationRuleCreateOptions): fix actions type types: fix actions type in automod Dec 22, 2022
@Jiralite Jiralite added this to the discord.js v14.8 milestone Dec 22, 2022
@kodiakhq kodiakhq bot merged commit 5915f39 into discordjs:main Dec 25, 2022
@kyranet kyranet mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js 14.8
Development

Successfully merging this pull request may close these issues.

Typings are incorrect for automod actions
5 participants
@MrMythicalYT @vladfrangu @kyranet @SpaceEEC @Jiralite