refactor: call GuildBanManager#create() directly
#9263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
jaw0r3k
approved these changes
Mar 21, 2023
vladfrangu
approved these changes
Mar 21, 2023
kyranet
approved these changes
Mar 22, 2023
TetieWasTaken
force-pushed
the
direct-ban
branch
from
3d4598a
to
9e1f9b6
Compare
|
@TetieWasTaken is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-tetiewastaken-direct-ban-discordjs.vercel.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Instead of calling
GuildBanManager#ban()atGuildMember#ban(), we callGuildBanManager#create()directly. SinceGuildMemberManager#ban()simply callsGuildBanManager#create()aswell. Thus skipping a useless redirect.discord.js/packages/discord.js/src/structures/GuildMember.js
Lines 384 to 386 in 950fc47
discord.js/packages/discord.js/src/managers/GuildMemberManager.js
Lines 484 to 486 in 950fc47
discord.js/packages/discord.js/src/managers/GuildBanManager.js
Line 154 in 950fc47
Status and versioning classification: