Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): abstract gateway #9410

Merged
merged 2 commits into from
Apr 17, 2023
Merged

feat(core): abstract gateway #9410

merged 2 commits into from
Apr 17, 2023

Conversation

didinele
Copy link
Member

@didinele didinele commented Apr 17, 2023 •
edited by ghost
Loading

Please describe the changes this PR makes and why it should be merged:

🤖 Generated by Copilot at 830995b

Sing, O Muse, of the cunning refactorer
Who devised a new interface Gateway
To separate the client from the web socket
And make it work with many a different way.

Status and versioning classification:

@didinele didinele added this to the core 0.6.0 milestone Apr 17, 2023
@didinele didinele requested a review from a team as a code owner April 17, 2023 14:57
@vercel
Copy link

vercel bot commented Apr 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 7:02pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 7:02pm

@github-actions
Copy link

github-actions bot commented Apr 17, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-feat-core-abstract-gateway-discordjs.vercel.app/

@kodiakhq kodiakhq bot merged commit 5d1a4c2 into main Apr 17, 2023
@kodiakhq kodiakhq bot deleted the feat/core-abstract-gateway branch April 17, 2023 20:05
@Jiralite Jiralite mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D4isDAVID D4isDAVID D4isDAVID left review comments

@Syjalo Syjalo Syjalo left review comments

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:core semver:major
Projects
discord.js
Archived in project
Milestone
core 0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@didinele @iCrawl @kyranet @Jiralite @D4isDAVID @Syjalo