Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide): Port slash commands sections #9553

Closed
wants to merge 4 commits into from

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented May 8, 2023

This ports the Slash commands section of the guide to the new one.
Supersedes #9507 because I accidentally broke my old PR.

  • Closes GDE-66
  • Closes GDE-67
  • Closes GDE-68
  • Closes GDE-69
  • Closes GDE-70
  • Closes GDE-71
  • Closes GDE-72

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 7:16am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 24, 2023 7:16am

@github-actions
Copy link

github-actions bot commented May 8, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 94
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-git-fork-monbrey-port-slash-commands-discordjs.vercel.app/


## Option types

By specifying the _`type`_ of an <DocsLink type="typedef" parent="ApplicationCommandOptionData" /> using the <DocsLink type="typedef" parent="ApplicationCommandOptionType" /> enum you are able to restrict what the user can provide as input, and for some options, leverage the automatic parsing of options into proper objects by Discord.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ApplicationCommandOptionType is actually from discord-api-types.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, make DocsLink support it 😀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support added for this in 7b617bd!

Jiralite and others added 4 commits August 24, 2023 09:13
Co-Authored-By: Ryan Munro <monbrey@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
@Jiralite
Copy link
Member

Superseded by #10013.

@Jiralite Jiralite closed this Dec 14, 2023
@monbrey monbrey deleted the port-slash-commands branch September 12, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants