chore: unpin rest, unbump node version req #9632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckohen
requested review from
vladfrangu,
didinele,
kyranet,
Jiralite and
SpaceEEC
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
didinele
approved these changes
Jun 9, 2023
iCrawl
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
#9512 added to /rest and used that method within djs. Upon publishing, this would break unless we unpinned the version or manually published a version of /rest with that change.
Looking at the breaking changes that made us pin, the most important was the node version bump, which after the change in scope of #9416 was not actually necessary. I've reverted the node version bump and unpinned /rest and /ws in discord.js.
This is an acknowledgement that there will be breaking changes, caveat being that an overwhelmingly large portion of the userbase will not actually be impacted whatsoever as they'd have to be using relatively very low level apis to be impacted.
Status and versioning classification: