FIX: Request signing and signature verification fixes #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Application actor as default request signer. - Only require signature verification when necessary.
pmusaraj
approved these changes
Dec 22, 2023
| @@ -23,6 +23,7 @@ def ensure_can_access_actor | |||
| end | |||
|
|
|||
| def ensure_can_access_actor_model | |||
| return true if @actor.ap.application? | |||
There was a problem hiding this comment.
When my local ENV is marked as login_required, I can't follow a remote Discourse instance, and it looks like that is because the remote instance is calling this route to get actor info and it is failing at the ensure_can_access_actor check (just above), this seems to return false:
DiscourseActivityPub.publishing_enabled || @actor.ap.group?
When I change that to
DiscourseActivityPub.publishing_enabled || @actor.ap.group? || @actor.ap.application?
the follow action works. Note though that then I can't unfollow the category, possibly because the Undo action also isn't permitted under a login_required scenario?
There was a problem hiding this comment.
Well caught. This will fix both: angusmcleod@ae0978b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pmusaraj This will fix the issue you were having.