DEV: Move Activity Pub configuration to dedicated admin panel #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@angusmcleod so sorry for the delay here, I'm now ready to review this, but any chance you can address the merge conflict with main? |
|
@pmusaraj Ready! |
pmusaraj
changed the title
pmusaraj
approved these changes
Apr 18, 2024
| @options={{hash | ||
| none="admin.discourse_activity_pub.actor.model_type.none" | ||
| }} | ||
| /> |
There was a problem hiding this comment.
For a followup, since we're only going to have one of two options here (a category or a tag), I would prefer a radio button or something else here other than a dropdown. It's fine for now, though.
There was a problem hiding this comment.
It's possible there could also be Group (i.e. user group) and even custom Persons (i.e. users) here too. We may not have either, but other actor types are conceivable.
|
Oh one last thing @angusmcleod, it would be more consistent if the UI for this was under the plugins tab. As in:
Hopefully that's not too big of an ask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pmusaraj This moves the ActivityPub settings to a dedicated admin panel, which both prepares us for Tag actors and also improves the Actor CRUD (e.g. the extension to category custom fields is no longer required).