DEV: Update test setup to work with auto groups #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
force-pushed
the
dev/update-test-setup-to-work-with-auto-groups
branch
from
b2f17e4
to
27e9bc2
Compare
Drenmi
force-pushed
the
dev/update-test-setup-to-work-with-auto-groups
branch
from
27e9bc2
to
cdfddb7
Compare
Drenmi
commented
Jan 15, 2024
Comment on lines
+92
to
+93
| before { User.set_callback(:create, :after, :ensure_in_trust_level_group) } | ||
| after { User.skip_callback(:create, :after, :ensure_in_trust_level_group) } |
There was a problem hiding this comment.
A little bit ugly, to avoid this ugly: https://github.com/discourse/discourse/blob/main/spec/rails_helper.rb#L244-L245
This is because the plugin creates new users deep within its belly, and they need the auto-groups for the tag creation not to fail.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
We're updating core to change TL based access settings to be group based. This requires some updates of tests to work correctly. (The existing test setup gives false positives.)