Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Convert min_trust_level_to_tag_topics to groups #25273

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

Drenmi
Copy link
Contributor

@Drenmi Drenmi commented Jan 16, 2024

Meta

What is this change?

We're changing the implementation of trust levels to use groups. Part of this is to have site settings that reference trust levels use groups instead. It converts the min_trust_level_to_tag_topics site setting to tag_topic_allowed_groups.

Plugin test updates

@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Jan 16, 2024
@Drenmi Drenmi force-pushed the dev/convert-min-trust-level-to-tag-topics-to-group branch 2 times, most recently from c175adf to 47ff035 Compare January 16, 2024 04:08
@Drenmi Drenmi marked this pull request as ready for review January 16, 2024 04:09
Copy link
Contributor

@martin-brennan martin-brennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, lgtm!

@martin-brennan
Copy link
Contributor

martin-brennan commented Jan 16, 2024

@Drenmi still 39 failures unfortunately :'(

@Drenmi Drenmi force-pushed the dev/convert-min-trust-level-to-tag-topics-to-group branch from 47ff035 to ad22b57 Compare January 16, 2024 07:00
@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label Jan 23, 2024
@Drenmi Drenmi force-pushed the dev/convert-min-trust-level-to-tag-topics-to-group branch 5 times, most recently from 4b8c598 to 0d46753 Compare January 25, 2024 00:41
@Drenmi Drenmi force-pushed the dev/convert-min-trust-level-to-tag-topics-to-group branch 2 times, most recently from 77cddf4 to 9e8189a Compare January 26, 2024 02:34
@Drenmi Drenmi force-pushed the dev/convert-min-trust-level-to-tag-topics-to-group branch from 9e8189a to 22b21a9 Compare January 26, 2024 02:46
@Drenmi Drenmi merged commit 7e5d2a9 into main Jan 26, 2024
19 checks passed
@Drenmi Drenmi deleted the dev/convert-min-trust-level-to-tag-topics-to-group branch January 26, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat PRs which include a change to Chat plugin i18n PRs which update English locale files or i18n related code
2 participants