FEATURE: Move query limit to hidden site setting #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
reviewed
Jan 19, 2022
tgxworld
reviewed
Jan 19, 2022
martin-brennan
force-pushed
the
feature/add-hidden-query-limit-setting
branch
from
015a353
to
38d2596
Compare
Previously the `QUERY_RESULT_DEFAULT_LIMIT` const was used to limit the number of query results. This commit adds the `data_explorer_query_result_limit` site setting which defaults to 1000 and has a max of 10000 which matches the const `QUERY_RESULT_MAX_LIMIT`.
martin-brennan
force-pushed
the
feature/add-hidden-query-limit-setting
branch
from
38d2596
to
35b4bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
QUERY_RESULT_DEFAULT_LIMITconst was usedto limit the number of query results. This commit adds the
data_explorer_query_result_limitsite setting which defaultsto 1000 and has a max of 10000 which matches the const
QUERY_RESULT_MAX_LIMIT.