Various improvements #116
Merged
Various improvements #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to fetch mentions, hashtags and uploads for each post which caused a lot of API calls (one per entity type per post). This reduces the number of API calls to one per entity.
udan11
force-pushed
the
develop
branch
5 times, most recently
from
ac6fd9a
to
9c0c956
Compare
eviltrout
approved these changes
Jul 26, 2021
| @@ -31,10 +33,10 @@ export default Ember.Controller.extend(ModalFunctionality, { | |||
|
|
|||
| actions: { | |||
| copy() { | |||
| const $copyRange = $("pre.exported-key-pair"); | |||
| if (copyText("", $copyRange[0])) { | |||
| const copyRange = document.querySelector("pre.exported-key-pair"); | |||
There was a problem hiding this comment.
(I realize this didn't change here but we might want a different way to export these in the future that doesn't rely on selecting the DOM.)
| const iv = download.buffer.slice(0, 12); | ||
| const content = download.buffer.slice(12); | ||
|
|
||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
I'm curious about the need to do new Promise here when window.crypto.subtle.decrypt seems to return a promise? Could you not return that?
There was a problem hiding this comment.
I can, but the tests might not work anymore. The runloop is aware of Ember Promises, but is not of the native ones:
https://discuss.emberjs.com/t/readers-questions-why-does-ember-still-use-rsvp/14736
Encrypted image uploads were displayed only in post body. This commit fixes the bug which enlarged small uploaded images.
This commit includes a fix to the problem of same topic title being displayed to every encrypted topic. The root cause was that jQuery's `data` method did not return the value of `data-topic-id` attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various performance improvements and uploads-related bug fixes. See each individual commit.