FIX: value of 'required' attr is string in 'fields' params. (#49)

Previously, since we treated it as a boolean it returned `true` even when the value is `"false"` string.
discourse · Oct 3, 2023 · 23ad490 · 23ad490
1 parent b881d6b
commit 23ad490
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/app/controllers/discourse_jira/issues_controller.rb b/app/controllers/discourse_jira/issues_controller.rb
@@ -57,7 +57,7 @@ def create
 
       (params[:fields] || []).each do |_, data|
         next if data.blank?
-        next if data[:value].blank? && !data[:required]
+        next if data[:value].blank? && data[:required] != "true"
 
         case data[:field_type]
         when "array"

diff --git a/spec/requests/issues_controller_spec.rb b/spec/requests/issues_controller_spec.rb
@@ -98,6 +98,11 @@
                    value: "windows",
                    field_type: "option",
                  },
+                 "2": {
+                   key: "customfield_10010",
+                   field_type: "array",
+                   required: "false",
+                 },
                },
              }
       end.to change { Post.count }.by(1)