Skip to content

Commit

Permalink
FIX: ensure ember transitions do not get hijacked by discourse interc…
Browse files Browse the repository at this point in the history
…ept-click

explicit null checks as a blank string evaluates to false
  • Loading branch information
featheredtoast committed Jan 8, 2019
1 parent d752620 commit 09cbd08
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/assets/javascripts/discourse/lib/intercept-click.js.es6
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ export default function interceptClick(e) {
!href ||
href === "#" ||
$currentTarget.attr("target") ||
$currentTarget.data("ember-action") ||
$currentTarget.data("auto-route") ||
$currentTarget.data("share-url") ||
$currentTarget.data("ember-action") != null ||
$currentTarget.data("auto-route") != null ||
$currentTarget.data("share-url") != null ||
$currentTarget.hasClass("widget-link") ||
$currentTarget.hasClass("raw-link") ||
$currentTarget.hasClass("mention") ||
Expand Down

1 comment on commit 09cbd08

@discoursebot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/going-back-to-previous-internal-page-after-404/104067/8

Please sign in to comment.