FIX: don't send multiple requests when changing category notification (…

…#6435)
discourse · Oct 1, 2018 · 1add11d · 1add11d · discoursebot · Oct 2, 2018
1 parent e2770bc
commit 1add11d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/assets/javascripts/select-kit/components/category-notifications-button.js.es6 b/app/assets/javascripts/select-kit/components/category-notifications-button.js.es6
@@ -11,5 +11,7 @@ export default NotificationOptionsComponent.extend({
 
   mutateValue(value) {
     this.get("category").setNotification(value);
-  }
+  },
+
+  deselect() {}
 });
diff --git a/app/models/category_user.rb b/app/models/category_user.rb
@@ -55,7 +55,11 @@ def self.set_notification_level_for_category(user, level, category_id)
       record.notification_level = level
       record.save!
     else
-      CategoryUser.create!(user: user, category_id: category_id, notification_level: level)
+      begin
+        CategoryUser.create!(user: user, category_id: category_id, notification_level: level)
+      rescue ActiveRecord::RecordNotUnique
+        # does not matter
+      end
     end
 
     auto_watch(user_id: user.id)