Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PERF: Check for modal visibility in a more efficient way
This code runs on every keyup event in the application, so it needs to be efficient. Previously we were iterating over the whole document using the JQuery :visible selector. Per the JQuery docs at https://api.jquery.com/visible-selector/ > Using this selector heavily can have performance implications, as it may force the browser to re-render the page before it can determine visibility. Tracking the visibility of elements via other methods, using a class for example, can provide better performance. We already had a `hidden` class on the modal element which we can check, so we can check that instead.
- Loading branch information