DEV: Do not delete failed uploads from S3 in debug mode (#14143)

See also 58e9fff
discourse · Aug 25, 2021 · a7ec1a8 · a7ec1a8
1 parent d2fe46d
commit a7ec1a8
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/app/services/external_upload_manager.rb b/app/services/external_upload_manager.rb
@@ -84,12 +84,11 @@ def promote_to_upload!
       external_upload_stub.created_by_id
     )
   rescue
-    # We don't need to do anything special to abort multipart uploads here,
-    # because at this point (calling promote_to_upload!), the multipart
-    # upload would already be complete.
-    Discourse.store.delete_file(external_upload_stub.key)
-
     if !SiteSetting.enable_upload_debug_mode
+      # We don't need to do anything special to abort multipart uploads here,
+      # because at this point (calling promote_to_upload!), the multipart
+      # upload would already be complete.
+      Discourse.store.delete_file(external_upload_stub.key)
       external_upload_stub.destroy!
     else
       external_upload_stub.update(status: ExternalUploadStub.statuses[:failed])