Permalink
Browse files

PERF: optimise new/unread query

This is part 1 of the work, need some internal cleanup to follow

new query seems to handle very large sets very efficiently
  • Loading branch information...
SamSaffron committed Sep 29, 2015
1 parent 42925b4 commit bc8c6d1a979a00ccd530a9f0124db970092c32e2
Showing with 8 additions and 8 deletions.
  1. +8 −8 app/models/topic_tracking_state.rb
@@ -128,13 +128,9 @@ def self.report(user_id, topic_id = nil)
# cycles from usual requests
#
#
sql = report_raw_sql(topic_id: topic_id)

sql = <<SQL
WITH x AS (
#{sql}
) SELECT * FROM x LIMIT #{SiteSetting.max_tracked_new_unread.to_i}
SQL
sql = report_raw_sql(topic_id: topic_id, skip_unread: true, skip_order: true)
sql << "\nUNION ALL\n\n"
sql << report_raw_sql(topic_id: topic_id, skip_new: true, skip_order: true)

SqlBuilder.new(sql)
.map_exec(TopicTrackingState, user_id: user_id, topic_id: topic_id)
@@ -198,7 +194,11 @@ def self.report_raw_sql(opts=nil)
sql << " AND topics.id = :topic_id"
end

sql << " ORDER BY topics.bumped_at DESC"
unless opts && opts[:skip_order]
sql << " ORDER BY topics.bumped_at DESC"
end

sql
end

end

0 comments on commit bc8c6d1

Please sign in to comment.