Skip to content

Commit

Permalink
FEATURE: Batch process topic bulk actions (#10980)
Browse files Browse the repository at this point in the history
Topics are processed in chunks of 30 in order to prevent timeouts.
  • Loading branch information
gschlager committed Oct 30, 2020
1 parent ec35b35 commit cc74c3f
Show file tree
Hide file tree
Showing 3 changed files with 62 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import ModalFunctionality from "discourse/mixins/modal-functionality";
import Topic from "discourse/models/topic";
import Category from "discourse/models/category";
import bootbox from "bootbox";
import { Promise } from "rsvp";

const _buttons = [];

Expand Down Expand Up @@ -84,6 +85,7 @@ export default Controller.extend(ModalFunctionality, {

emptyTags: empty("tags"),
categoryId: alias("model.category.id"),
processedTopicCount: 0,

onShow() {
const topics = this.get("model.topics");
Expand All @@ -101,23 +103,70 @@ export default Controller.extend(ModalFunctionality, {
},

perform(operation) {
this.set("processedTopicCount", 0);
this.send("changeBulkTemplate", "modal/bulk-progress");
this.set("loading", true);

const topics = this.get("model.topics");
return Topic.bulkOperation(topics, operation)
.then((result) => {
this.set("loading", false);
if (result && result.topic_ids) {
return result.topic_ids.map((t) => topics.findBy("id", t));
}
return result;
})
return this._processChunks(operation)
.catch(() => {
bootbox.alert(I18n.t("generic_error"));
})
.finally(() => {
this.set("loading", false);
});
},

_generateTopicChunks(allTopics) {
let startIndex = 0;
const chunkSize = 30;
const chunks = [];

while (startIndex < allTopics.length) {
let topics = allTopics.slice(startIndex, startIndex + chunkSize);
chunks.push(topics);
startIndex += chunkSize;
}

return chunks;
},

_processChunks(operation) {
const allTopics = this.get("model.topics");
const topicChunks = this._generateTopicChunks(allTopics);
const topicIds = [];

const tasks = topicChunks.map((topics) => () => {
return Topic.bulkOperation(topics, operation).then((result) => {
this.set(
"processedTopicCount",
this.get("processedTopicCount") + topics.length
);
return result;
});
});

return new Promise((resolve, reject) => {
const resolveNextTask = () => {
if (tasks.length === 0) {
const topics = topicIds.map((id) => allTopics.findBy("id", id));
return resolve(topics);
}

tasks
.shift()()
.then((result) => {
if (result && result.topic_ids) {
topicIds.push(...result.topic_ids);
}
resolveNextTask();
})
.catch(reject);
};

resolveNextTask();
});
},

forEachPerformed(operation, cb) {
this.perform(operation).then((topics) => {
if (topics) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<p>{{html-safe (i18n "topics.bulk.progress" count=processedTopicCount)}}</p>
3 changes: 3 additions & 0 deletions config/locales/client.en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2199,6 +2199,9 @@ en:
choose_append_tags: "Choose new tags to append for these topics:"
changed_tags: "The tags of those topics were changed."
remove_tags: "Remove Tags"
progress:
one: "Progress: <strong>%{count}</strong> topic"
other: "Progress: <strong>%{count}</strong> topics"

none:
unread: "You have no unread topics."
Expand Down

0 comments on commit cc74c3f

Please sign in to comment.