Feature: Change markdown engine to markdown it

This commit removes the old evilstreak markdownjs engine.

- Adds specs to WhiteLister and changes it to stop using globals
    (Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
    CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs

Gemfile.lock

@@ -156,7 +156,7 @@ GEM
     mime-types (2.99.3)
     mini_mime (0.1.3)
     mini_portile2 (2.2.0)
-    mini_racer (0.1.9)
+    mini_racer (0.1.10)
       libv8 (~> 5.3)
     minitest (5.10.2)
     mocha (1.2.1)

app/assets/javascripts/markdown-it-bundle.js

@@ -1,15 +1,15 @@
 //= require markdown-it.js
-//= require ./pretty-text/engines/markdown-it/helpers
-//= require ./pretty-text/engines/markdown-it/mentions
-//= require ./pretty-text/engines/markdown-it/quotes
-//= require ./pretty-text/engines/markdown-it/emoji
-//= require ./pretty-text/engines/markdown-it/onebox
-//= require ./pretty-text/engines/markdown-it/bbcode-block
-//= require ./pretty-text/engines/markdown-it/bbcode-inline
-//= require ./pretty-text/engines/markdown-it/code
-//= require ./pretty-text/engines/markdown-it/category-hashtag
-//= require ./pretty-text/engines/markdown-it/censored
-//= require ./pretty-text/engines/markdown-it/table
-//= require ./pretty-text/engines/markdown-it/paragraph
-//= require ./pretty-text/engines/markdown-it/newline
-//= require ./pretty-text/engines/markdown-it/html_img
+//= require ./pretty-text/engines/discourse-markdown/helpers
+//= require ./pretty-text/engines/discourse-markdown/mentions
+//= require ./pretty-text/engines/discourse-markdown/quotes
+//= require ./pretty-text/engines/discourse-markdown/emoji
+//= require ./pretty-text/engines/discourse-markdown/onebox
+//= require ./pretty-text/engines/discourse-markdown/bbcode-block
+//= require ./pretty-text/engines/discourse-markdown/bbcode-inline
+//= require ./pretty-text/engines/discourse-markdown/code
+//= require ./pretty-text/engines/discourse-markdown/category-hashtag
+//= require ./pretty-text/engines/discourse-markdown/censored
+//= require ./pretty-text/engines/discourse-markdown/table
+//= require ./pretty-text/engines/discourse-markdown/paragraph
+//= require ./pretty-text/engines/discourse-markdown/newline
+//= require ./pretty-text/engines/discourse-markdown/html_img

app/assets/javascripts/pretty-text-bundle.js

@@ -3,11 +3,8 @@
 //= require ./pretty-text/censored-words
 //= require ./pretty-text/emoji/data
 //= require ./pretty-text/emoji
-//= require ./pretty-text/engines/discourse-markdown
 //= require ./pretty-text/engines/discourse-markdown-it
-//= require_tree ./pretty-text/engines/discourse-markdown
 //= require xss.min
-//= require better_markdown.js
 //= require ./pretty-text/xss
 //= require ./pretty-text/white-lister
 //= require ./pretty-text/sanitizer

app/assets/javascripts/pretty-text/engines/discourse-markdown-it.js.es6

@@ -1,4 +1,4 @@
-import { default as WhiteLister, whiteListFeature } from 'pretty-text/white-lister';
+import { default as WhiteLister } from 'pretty-text/white-lister';
 import { sanitize } from 'pretty-text/sanitizer';
 import guid from 'pretty-text/guid';
 
@@ -10,10 +10,10 @@ function deprecate(feature, name){
   };
 }
 
-function createHelper(featureName, opts, optionCallbacks, pluginCallbacks, getOptions) {
+function createHelper(featureName, opts, optionCallbacks, pluginCallbacks, getOptions, whiteListed) {
   let helper = {};
   helper.markdownIt = true;
-  helper.whiteList = info => whiteListFeature(featureName, info);
+  helper.whiteList = info => whiteListed.push([featureName, info]);
   helper.registerInline = deprecate(featureName,'registerInline');
   helper.replaceBlock = deprecate(featureName,'replaceBlock');
   helper.addPreProcessor = deprecate(featureName,'addPreProcessor');
@@ -151,7 +151,7 @@ export function setup(opts, siteSettings, state) {
   }
 
   // we got to require this late cause bundle is not loaded in pretty-text
-  Helpers = Helpers || requirejs('pretty-text/engines/markdown-it/helpers');
+  Helpers = Helpers || requirejs('pretty-text/engines/discourse-markdown/helpers');
 
   opts.markdownIt = true;
 
@@ -165,6 +165,7 @@ export function setup(opts, siteSettings, state) {
 
   const check = /discourse-markdown\/|markdown-it\//;
   let features = [];
+  let whiteListed = [];
 
   Object.keys(require._eak_seen).forEach(entry => {
     if (check.test(entry)) {
@@ -173,7 +174,7 @@ export function setup(opts, siteSettings, state) {
 
         const featureName = entry.split('/').reverse()[0];
         features.push(featureName);
-        module.setup(createHelper(featureName, opts, optionCallbacks, pluginCallbacks, getOptions));
+        module.setup(createHelper(featureName, opts, optionCallbacks, pluginCallbacks, getOptions, whiteListed));
       }
     }
   });
@@ -227,10 +228,16 @@ export function setup(opts, siteSettings, state) {
   opts.markdownIt = true;
   opts.setup = true;
 
-  if (!opts.discourse.sanitizer) {
+  if (!opts.discourse.sanitizer || !opts.sanitizer) {
     const whiteLister = new WhiteLister(opts.discourse);
+
+    whiteListed.forEach(([feature, info]) => {
+      whiteLister.whiteListFeature(feature, info);
+    });
+
     opts.sanitizer = opts.discourse.sanitizer = (!!opts.discourse.sanitize) ? a=>sanitize(a, whiteLister) : a=>a;
   }
+
 }
 
 export function cook(raw, opts) {