FIX: Error with ace editor and new ember.

Fix upgrades ace editor, which was a huge headache due to AMD.

.jshintrc

@@ -35,6 +35,7 @@
     "exists",
     "visible",
     "invisible",
+    "asyncRender",
     "selectDropdown",
     "asyncTestDiscourse",
     "fixture",

app/assets/javascripts/admin/components/ace-editor.js.es6

@@ -1,5 +1,4 @@
-/*global ace:true */
-
+/* global ace:true */
 import loadScript from 'discourse/lib/load-script';
 
 export default Ember.Component.extend({
@@ -33,19 +32,21 @@ export default Ember.Component.extend({
     const self = this;
 
     loadScript("/javascripts/ace/ace.js", { scriptTag: true }).then(function() {
-      const editor = ace.edit(self.$('.ace')[0]);
-
-      editor.setTheme("ace/theme/chrome");
-      editor.setShowPrintMargin(false);
-      editor.getSession().setMode("ace/mode/" + (self.get('mode')));
-      editor.on('change', function() {
-        self._skipContentChangeEvent = true;
-        self.set('content', editor.getSession().getValue());
-        self._skipContentChangeEvent = false;
+      ace.require(['ace/ace'], function(loadedAce) {
+        const editor = loadedAce.edit(self.$('.ace')[0]);
+
+        editor.setTheme("ace/theme/chrome");
+        editor.setShowPrintMargin(false);
+        editor.getSession().setMode("ace/mode/" + (self.get('mode')));
+        editor.on('change', function() {
+          self._skipContentChangeEvent = true;
+          self.set('content', editor.getSession().getValue());
+          self._skipContentChangeEvent = false;
+        });
+
+        self.$().data('editor', editor);
+        self._editor = editor;
       });
-
-      self.$().data('editor', editor);
-      self._editor = editor;
     });
 
   }.on('didInsertElement')

app/assets/javascripts/discourse/lib/load-script.js.es6

@@ -7,12 +7,16 @@ function loadWithTag(path, cb) {
 
   let s = document.createElement('script');
   s.src = path;
+  if (Ember.Test) { Ember.Test.pendingAjaxRequests++; }
   head.appendChild(s);
 
   s.onload = s.onreadystatechange = function(_, abort) {
+    if (Ember.Test) { Ember.Test.pendingAjaxRequests--; }
     if (abort || !s.readyState || s.readyState === "loaded" || s.readyState === "complete") {
       s = s.onload = s.onreadystatechange = null;
-      if (!abort) { cb(); }
+      if (!abort) {
+        Ember.run(null, cb);
+      }
     }
   };
 }