Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: allows PM owner to remove any user if >= TL2 #10036

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented Jun 12, 2020

  • < TL2 user can remove itself:

Screenshot 2020-06-12 at 10 35 50

  • >= TL2 user can remove everyone:

Screenshot 2020-06-12 at 10 35 58

@jjaffeux jjaffeux requested a review from ZogStriP June 12, 2020 08:43
@ZogStriP
Copy link
Member

What happens if OP remove themselves from the PM? 🤔

@jjaffeux
Copy link
Contributor Author

jjaffeux commented Jun 12, 2020

What happens if OP remove themselves from the PM? 🤔

replaced by system user

Screenshot 2020-06-12 at 12 11 59

So we keep trace of the OP being crated by this user, but we replace its presence in the topic by system. Also "bob" here, can no longer access/see this.

Note 1: the screenshot is done with a staff account, so this is why you can see "Add or Remove"
Note 2: the small action text is a little bit weird: "Bob removed themselves....", I think it's ok though, very rare use case...

@jjaffeux jjaffeux merged commit 4b793a1 into discourse:master Jun 12, 2020
@jjaffeux jjaffeux deleted the pm-remove-any-user-if-tl2 branch June 12, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants