FIX: Remove social sharing icons from private contexts #10213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaffeux
reviewed
Jul 13, 2020
jjaffeux
reviewed
Jul 13, 2020
| @@ -16,7 +16,10 @@ export default Component.extend({ | |||
|
|
|||
| @discourseComputed | |||
| sources() { | |||
| return Sharing.activeSources(this.siteSettings.share_links); | |||
| const privateContext = | |||
There was a problem hiding this comment.
Do we need to compute on this.topic.isPrivateMessage here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Twitter/Facebook icons in the share dialogs when:
Themes/plugins can use the new
showInPrivateContextoption to add their source to these private contexts.