DEV: Don't lint core files when target == plugins #10259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me :) feel free to merge |
.github/workflows/ci.yml
Outdated
| if: env.BUILD_TYPE == 'LINT' && env.TARGET == 'PLUGINS' | ||
| run: | | ||
| yarn prettier -v | ||
| yarn prettier --list-different "plugins/**/*.scss" "plugins/**/*.es6" |
There was a problem hiding this comment.
Do we need to add .js here, since we have stopped using .es6 in some plugins?
There was a problem hiding this comment.
Ha, good eye! So we were not linting some files then. 😅
There was a problem hiding this comment.
Yeah I guess so!
Sorry to bring it up in this PR, it's not really related. Maybe we should fix that separately?
There was a problem hiding this comment.
Too late, added to this PR 😜
There was a problem hiding this comment.
Looks like we were indeed missing some linting failures 😅
This reverts commit ec6dd2a.
|
looks like we have general approval here @CvX can you merge when you start your day ? |
|
@CvX Is this good to merge? |
# Conflicts: # .github/workflows/ci.yml
This reverts commit 3204783.
|
Now it is 😃 |
|
Merge away :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less work for the GitHub Actions and less noise in the results.