Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Remove the <details> polyfill #10260

Merged
merged 2 commits into from Jul 20, 2020
Merged

DEV: Remove the <details> polyfill #10260

merged 2 commits into from Jul 20, 2020

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Jul 17, 2020

Per the linked site (http://mths.be/details) and https://caniuse.com/#feat=details the <details> element is supported since Chrome 12/Safari 6/Firefox 49/Edge 79. IE 11 doesn't handle it but we dropped the support for that browser.

Removing this fixes the lint issues uncovered in #10259.

@CvX CvX marked this pull request as draft July 17, 2020 13:14
CvX added 2 commits July 17, 2020 19:10
Per the linked site (http://mths.be/details) and https://caniuse.com/#feat=details the <details> element is supported since Chrome 12/Safari 6/Firefox 49/Edge 79. IE 11 doesn't handle them, but we dropped the support for that browser.
@CvX CvX marked this pull request as ready for review July 17, 2020 17:35
@CvX CvX requested a review from ZogStriP July 20, 2020 11:02
Copy link
Member

@ZogStriP ZogStriP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code is always better code 👍

@CvX CvX merged commit 8f2f9e6 into master Jul 20, 2020
@CvX CvX deleted the drop-details-polyfill branch July 20, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants