UX: show a generic error on upload for XHR status 0 #10521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could use suggestions on copy, if anyone has them. |
eviltrout
approved these changes
Aug 25, 2020
This indication covers all cases of network errors, not just "cancelled by user". The post upload component already has its own handling for user-cancelled uploads, but the generic upload component does not. Tested by stopping my localhost server right before attempting to upload a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indication covers all cases of network errors, not just "cancelled by user".
The post upload component already has its own handling for user-cancelled uploads, but the generic upload component does not.
Because this error code frequently indicates the browser is refusing to tell the page what's wrong, suggest checking the developer console.
Tested by stopping my localhost server right before attempting to upload a file (browser's net::ERR_CONNECTION_REFUSED).