FEATURE: Include rejected queued posts in the user archive export #10859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eviltrout you wrote most of the new Reviewable code - is there anything that might generically end up in |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
|
@riking it seems a bit dangerous to export everything in the JSON by default. I know some plugins like twohat for example are storing metadata in there about their classification. I think we should only export certain things. We could start with the |
Requested at https://meta.discourse.org/t/where-can-a-user-find-the-post-that-was-rejected-by-the-moderator/165671?u=riking Field whitelisting is applied to the json field using Hash#slice, which was activesupport until Ruby 2.5.
riking
force-pushed
the
exporting-queued
branch
from
60a53ef
to
ef1e5f3
Compare
|
@eviltrout Found |
eviltrout
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested at https://meta.discourse.org/t/where-can-a-user-find-the-post-that-was-rejected-by-the-moderator/165671?u=riking
Field selection was hard to determine here, because there's no guarantee about what's in the json payload. I decided to include the entire thing, as it gets passed to the PostCreator with no field whitelisting.
Additionally, I spotted a stray IP address in the payload field on an older forum.