Remove more global variables from tests. #11017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviltrout
force-pushed
the
more-test-globals
branch
from
b3600c1
to
5b88903
Compare
CvX
approved these changes
Oct 24, 2020
| @@ -117,22 +118,22 @@ Object.keys(functionBindings).forEach((func) => { | |||
| }); | |||
|
|
|||
| test("selectDown calls _moveSelection with 1", (assert) => { | |||
| var stub = sandbox.stub(KeyboardShortcuts, "_moveSelection"); | |||
| var stub = sinon.stub(KeyboardShortcuts, "_moveSelection"); | |||
There was a problem hiding this comment.
I see you replaced var with let in other files in this PR but not those in this one. (except a single instance at the top)
Do you want to update this PR or do a second one that updates all vars across all tests?
* Use `sinon` instead of `sandbox` and require an import. * You need to import `currentURL` to use it.
eviltrout
force-pushed
the
more-test-globals
branch
from
5b88903
to
9c32ff5
Compare
|
@CvX yes I probably should have changed those while I was in there. I've pushed an update that changes them to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinoninstead ofsandboxand require an import.currentURLto use it.