Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Force string conversions to UTF-8 "bytes" #11315

Merged
merged 3 commits into from
Nov 23, 2020
Merged

FIX: Force string conversions to UTF-8 "bytes" #11315

merged 3 commits into from
Nov 23, 2020

Conversation

chenyxuan
Copy link
Contributor

No description provided.

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/cant-create-poll-with-some-chinese-options/170836/2

ZogStriP
ZogStriP requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@ZogStriP ZogStriP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Can you also add a test with a poll with Chinese options to ensure it works properly in the future?

@ZogStriP
Copy link
Member

Looks like there are trailing whitespaces in the specs. Can you remove them?

@chenyxuan
Copy link
Contributor Author

Thanks Zog. It's nice collaborating with you.

@ZogStriP ZogStriP merged commit defbae4 into discourse:master Nov 23, 2020
@ZogStriP
Copy link
Member

Thanks a lot @chenyxuan 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZogStriP ZogStriP ZogStriP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyxuan @discoursebot @ZogStriP