DEV: Correct the ruby version check #12551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix discourse cannot work with ruby 3.0.0
|
|
tisonkun
changed the title
|
for totally compatible with ruby 3.0.0 we still need to fix issues such as this one. but change the way we compare semver is always a net win. |
CvX
approved these changes
Mar 30, 2021
CvX
approved these changes
Mar 30, 2021
CvX
changed the title
|
Thank you! 😃 |
|
@CvX thanks for your review! I'll try to run discourse on Ruby 3.0.0 later :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix discourse cannot work with ruby 3.0.0