DEV: Use Terser for JS minification/compression if available #12656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
approved these changes
Apr 8, 2021
talyz
added a commit
to talyz/nixpkgs
that referenced
this pull request
Jul 14, 2021
Discourse prefers to use `terser` when building js assets, see discourse/discourse#12656. It still wants to find `uglify-js` in order to not fall back to a ruby js compression library, so let's keep it around for now. A fix for this has been submitted upstream in discourse/discourse#13683.
dpausp
pushed a commit
to dpausp/nixpkgs
that referenced
this pull request
Oct 5, 2021
Discourse prefers to use `terser` when building js assets, see discourse/discourse#12656. It still wants to find `uglify-js` in order to not fall back to a ruby js compression library, so let's keep it around for now. A fix for this has been submitted upstream in discourse/discourse#13683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to Terser for JS compression, it is faster compared to uglify-js and supports more recent JS syntax (like the optional chaining operator).
Uglify-js is still used if terser is unavailable, but it will be removed at the next base image bump.