FEATURE: impersonation now requires second factor authorization #12662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arpitjalan
commented
Apr 9, 2021
arpitjalan
commented
arpitjalan
force-pushed
the
impersonation-2fa
branch
from
930692b
to
a663625
Compare
arpitjalan
force-pushed
the
impersonation-2fa
branch
from
a663625
to
63c1f3e
Compare
|
Quick question: why is the |
ZogStriP
reviewed
Apr 9, 2021
| second_factor_token: | ||
| this.securityKeyCredential || this.secondFactorToken, | ||
| second_factor_method: this.secondFactorMethod, | ||
| timezone: moment.tz.guess(), |
ZogStriP
reviewed
Apr 9, 2021
| }).then( | ||
| (result) => { | ||
| // Successful login | ||
| if (result && result.error) { |
There was a problem hiding this comment.
Is it a successful login if there's an error?
ZogStriP
reviewed
Apr 9, 2021
Comment on lines
+76
to
+79
| document | ||
| .getElementById("second-factor") | ||
| .querySelector("input") | ||
| .focus() |
There was a problem hiding this comment.
You could shorten that a bit.
Suggested change
| document | |
| .getElementById("second-factor") | |
| .querySelector("input") | |
| .focus() | |
| document.querySelector("#second-factor input").focus() |
|
sorry @techapj I am closing this, when you free up you can spend some time with @martin-brennan doing the "generic" reusable 2fa screen. Then it should be a breeze plugging this in anywhere we need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.