Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: adds an experimental preserveKey bool option to autocomplete #12751

Merged
merged 2 commits into from
Apr 19, 2021
Merged

DEV: adds an experimental preserveKey bool option to autocomplete #12751

merged 2 commits into from
Apr 19, 2021

Conversation

jjaffeux
Copy link
Contributor

Usage:

$(input).autocomplete({
  preserveKey: false
});

Defaults to true.

@jjaffeux
DEV: adds an experimental preserveKey bool option to autocomplete
b70437d 
Usage:

```
$(input).autocomplete({
  preserveKey: false
});
```

Defaults to true.
@jjaffeux jjaffeux requested a review from CvX April 19, 2021 09:18
@jjaffeux
Copy link
Contributor Author

Note that going with dropKey would make code slightly simpler, but I preferred preserveKey wording.

@jjaffeux jjaffeux mentioned this pull request Apr 19, 2021
Merged
@jjaffeux jjaffeux merged commit 99aae95 into discourse:master Apr 19, 2021
@jjaffeux jjaffeux deleted the preserve-key branch April 19, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjaffeux @CvX