A11Y: Improve navigation on topic lists for screen readers #13153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had no role set for various topic links, nor did we have any headers. This teaches screen readers that topic links in topic lists are to be treated as H2. We opted for this less radical change cause a change of the element type would probably result in many broken themes. Confirmed on NVDA you can very quickly breeze through topic lists now. Minor edge case is pinned topics which can be a bit annoying due to multiple links.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/discourse-with-a-screen-reader/178105/47 |
awesomerobot
approved these changes
May 26, 2021
awesomerobot
changed the title
nlalonde
pushed a commit
that referenced
this pull request
Jun 4, 2021
Previously we had no role set for various topic links, nor did we have any headers. This teaches screen readers that topic links in topic lists are to be treated as H2. We opted for this less radical change cause a change of the element type would probably result in many broken themes. Confirmed on NVDA you can very quickly breeze through topic lists now. Minor edge case is pinned topics which can be a bit annoying due to multiple links.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had no role set for various topic links, nor did we have any
headers.
This teaches screen readers that topic links in topic lists are to be treated
as H2. We opted for this less radical change cause a change of the element
type would probably result in many broken themes.
Confirmed on NVDA you can very quickly breeze through topic lists now. Minor
edge case is pinned topics which can be a bit annoying due to multiple links.