DEV: Add more keyboard shortcut acceptance tests #13280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OsamaSayegh
reviewed
Jun 4, 2021
app/assets/javascripts/discourse/tests/acceptance/keyboard-shortcuts-test.js
Show resolved
Hide resolved
tgxworld
reviewed
Jun 4, 2021
app/assets/javascripts/discourse/tests/acceptance/keyboard-shortcuts-test.js
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Jun 4, 2021
app/assets/javascripts/discourse/tests/acceptance/keyboard-shortcuts-test.js
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Jun 4, 2021
app/assets/javascripts/discourse/tests/acceptance/keyboard-shortcuts-test.js
Outdated
Show resolved
Hide resolved
tgxworld
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds acceptance tests for keyboard shortcuts to
dismiss new and unread topics.
Also, I cleaned out a few old specs for the unit test for
keyboard-shortcuts. Some were introduced way back in
5100c2b
but then supplanted by
9548876
and never cleaned up, so they were doing nothing.
Follow up to https://review.discourse.org/t/fix-dismiss-topics-keyboard-shortcut-not-working-pr-13260/22157/4?u=martin