FIX: TL4 users can see their deleted posts #13364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviltrout
approved these changes
Jun 11, 2021
SamSaffron
reviewed
Jun 15, 2021
lib/guardian/post_guardian.rb
Outdated
| @@ -233,7 +233,7 @@ def can_see_post?(post) | |||
| return true if is_admin? | |||
| return false unless can_see_topic?(post.topic) | |||
| return false unless post.user == @user || Topic.visible_post_types(@user).include?(post.post_type) | |||
| return false if !(is_moderator? || is_category_group_moderator?(post.topic.category)) && post.deleted_at.present? | |||
| return false if !(is_moderator? || is_category_group_moderator?(post.topic.category)) && (post.deleted_at.present? && post.deleted_by != @user) | |||
There was a problem hiding this comment.
this logic is getting a bit too complicated ... instead maybe?
return true if is_moderator || is_category_group_moderator?(post.topic.category)
return true post.deleted_at.present? && post_deleted_by_id == @user&.id
false
|
Since this is specifically about TL4 for extra safety I would recommend checking for TL4 |
ZogStriP
approved these changes
Jun 18, 2021
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/tl4-cant-undelete-their-own-posts/217913/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were able to delete their posts, but then could not recover them because they did not have the permissions to see them.