FEATURE: Make max number of favorite configurable #13480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZogStriP
reviewed
Jun 22, 2021
It used to be hardcoded to 2 and now it uses max_favorite_badges site setting. When zero, it disables favorite badges.
nbianca
force-pushed
the
feature_favorite_badges
branch
from
8191afe
to
aa29623
Compare
ZogStriP
approved these changes
Jun 22, 2021
discourse-translator-bot
pushed a commit
that referenced
this pull request
Jun 23, 2021
It used to be hardcoded to 2 and now it uses max_favorite_badges site setting. When zero, it disables favorite badges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be hardcoded to 2 and now it uses max_favorite_badges site
setting. When zero, it disables favorite badges.
desktop and mobile with max_favorite_badges = 3
desktop and mobile with max_favorite_badges = 5
desktop and mobile with max_favorite_badges = 0 (fallback to the old behavior)